Repository navigation
Conversation
local_relation and cached_local_relation (a host pre-pass builds the relations: the translator records requests on a first pass, the server builds them with Session::local_relation, a second pass resolves them), Read.DataSource.schema, SubqueryAlias.qualifier, nested array/map/struct/ specialized_array literals, expression_string through krishiv-sql, and the is_local arm. Coverage rows and PySpark goldens updated. Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
A SqlCommand runs through the new Session::sql_command (unstable-ir): a command (any statement but a query) runs at once and answers a LocalRelation of its rows as sql_command_result; a query is only analyzed and answers the SQL relation the client re-sends. translate_plan translates a sql_command as that SQL relation (sql_command_relation); input and parameters are refused. Coverage row sql_command is Partial. Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
- sql_command: use SqlCommand.input (what PySpark 4.x sends) when it is a SQL relation, answering it unchanged; WithRelations stays unsupported, any other relation is SQL_COMMAND_EXPECTS_SQL_OR_WITH_RELATIONS. - A command answers a metrics response after the result (as Spark does); the module doc is corrected. - LocalRelations::take_requests drains instead of cloning; the first-pass state is dropped before the build loop. - Nested-literal member mismatches are CONNECT_INVALID_PLAN.ASSERTION_FAILURE, not INTERNAL_ERROR. - A command result is capped at 0.7 x maxBatchSize; its time zone is read after the command ran. - Docs: alias_name error class, connect CLAUDE.md, coverage row. Signed-off-by: gopal tathe <gopal@users.noreply.github.com> Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
 |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Diff review passed (Opus, |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 10.77%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
dtolnay/rust-toolchain's `stable` branch was rewritten on 2026-11-15 02:32 UTC. The pinned commit b725eda5 no longer has history in that repository, so zizmor's impostor-commit audit now fails on every PR that touches a workflow (#769, #774). Repin the four uses (setup-rust action, binaries, docs-site) to the current `stable` head 39008827. Its action.yml is byte-identical to the old pin's, so the steps behave the same. Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
P3-T012a part 2b (PR-12): the Spark Connect translator arms for group 1. Stacked on #772 (part 2a, the IR); the base is that branch, so the diff is part 2b only. Merge #772 first.
local_relationandcached_local_relation(two-pass: the translator records requests, connect-server builds them withSession::local_relation, a second pass resolves them; no async trait). No artifact store on this base yet, so every cached hash answersNOT_FOUND_CACHED_LOCAL_RELATION;chunked_cached_local_relationstays 56K00.Read.DataSource.schema,SubqueryAlias.qualifier, nested array/map/struct/specialized_array literals,expression_string(SQL parser,ParserOptionsinTranslateConf), theis_localarm.sql_command(whatspark.sql()sends):Session::sql_command(unstable-ir) tells a command from a query; a command runs at once and answers aLocalRelationof its rows then a metrics response; a query answers theSQLrelation to re-send. Both the PySpark 4.xinputfield and the deprecatedsqlfield work.cargo xtask connect-coverage --checkclean).Opus diff review:
ops/reviews/2026-11-15-sonnet-1-t012a-part2b-diff.md(blocker, 3 majors, 2 minors fixed; see its Fixes section).Known gaps: a root
SQLrelation selecting from a temp view fails ("views not supported" in the plan analyzer on this base); parameterised SQL andWithRelationsinput refused; per-session byte budget for inline data is a follow-up. Golden-pending (Spark text/classes unverified) items are listed in the review and handoff.Not run locally: the full session and exec integration suites; CI covers them.